Skip to content

bpo-33403: Added return_on parameter to asyncio.tasks.wait coro#6679

Closed
pyneda wants to merge 2 commits intopython:masterfrom
pyneda:asyncio-wait-return-custom-exception
Closed

bpo-33403: Added return_on parameter to asyncio.tasks.wait coro#6679
pyneda wants to merge 2 commits intopython:masterfrom
pyneda:asyncio-wait-return-custom-exception

Conversation

@pyneda
Copy link
Copy Markdown

@pyneda pyneda commented May 2, 2018

Added return_on parameter to asyncio.tasks.wait coroutine in order to be able to set a custom exception or tuple of exceptions to return when return_when parameter is set to FIRST_EXCEPTION.

Uses Exception as default value in order to keep maintaining the actual behaviour of returning when any exception is raised when FIRST_EXCEPTION is used.

https://bugs.python.org/issue33403

@pyneda pyneda requested review from 1st1 and asvetlov as code owners May 2, 2018 00:40
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@pyneda
Copy link
Copy Markdown
Author

pyneda commented May 2, 2018

CLA should be signed

@matrixise
Copy link
Copy Markdown
Member

hi @1st1 and @asvetlov what do you think about this PR, there is no discussion in the issue. thank you.

Copy link
Copy Markdown
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a motivating use case for this. Please update the issue with one.

@bedevere-bot
Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants